search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

Creation date should be able to be different from the validation date #707

Open francescbassas opened 2 months ago

francescbassas commented 2 months ago

If I haven't misunderstood "Signature date" is set at the time of mandate is created. With the same date of "Creation date". Why?

I think it could be empty and It would have to be able to be defined a posteriori.

I see this commit https://github.com/Project60/org.project60.sepa/commit/d98f628f46d340d69b5d0b01f9cc1acd7c1cfdf2. Maybe DtOfSgntr could be defined with "Signature date" if is defined and with "Creation date" if "Signature date" is empty?

bjendres commented 1 month ago

Hi @francescbassas

There's currently three dates on the mandate: creation_date, validation_date, and date (which is "signature date").

"Signature date" is set at the time of mandate is created. With the same date of "Creation date". Why?

Usually because at the time of creation through the UI we don't have a dedicated signature date. However, I think the APIv3 allows you to set the two dates separately during creation.

I have never tried this, since nobody had a multiple significant dates, but if you do try let me know whether everything works correctly.

I think it could be empty and It would have to be able to be defined a posteriori.

Sure, but right now it defaults to the creation date, but you can still update it a posteriori - right?

I see this commit https://github.com/Project60/org.project60.sepa/commit/d98f628f46d340d69b5d0b01f9cc1acd7c1cfdf2. Maybe DtOfSgntr could be defined with "Signature date" if is defined and with "Creation date" if "Signature date" is empty?

Sure. If you want to add that to CiviSEPA, maybe create a separate file format, since some people might be relying on the dates being the same.