search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

Fix or issue 721 #722

Closed kainuk closed 3 months ago

kainuk commented 5 months ago

Fix for #721 , but it is done by restoring old code. So maybe I am missing something that could by fixed by changing something in the configuration.

What is a bit of a mystery for my is that the batch fails because the variable $this->origin_status_ids is NULL but I have no idea where it can be set.

Detsieber commented 3 months ago

I had this same issue on a large install (CiviCRM 5.74.4, CiviSEPA 1.10.0), and this fix is working for us. Thank you @kainuk so much!

Please merge.

peth-systopia commented 3 months ago

Fix for https://github.com/Project60/org.project60.sepa/issues/721 , but it is done by restoring old code.

Not sure this qualifies for merging without further investigation, so I added the 'needs funding' tag.

bjendres commented 3 months ago

Thanks @kainuk

MarcMichalsky commented 3 months ago

Not sure this qualifies for merging without further investigation

I have looked at the latest changes before the problem appeared. A method setOriginStatusIds() was added that is supposed to set $this->origin_status_ids, but I can't find any place in the repository where this method is used. Looks like a trivial mistake to me. The change by @kainuk just restores the old functionality.

Perhaps the original intention of the change should still be corrected and finalised, but the fix certainly helps to make the extension usable again in the meantime.

Thanks for fixing and merging!