search

Project60 / org.project60.sepapp

CiviCRM PaymentProcessor for CiviSEPA
Other
4 stars 4 forks source link

Update SDD.php #8

Closed Detsieber closed 2 years ago

Detsieber commented 2 years ago

String "Direct Debit" wasn't marked as ts() and therefore not translated -> fixed

bjendres commented 2 years ago

Thanks @Detsieber. I have pulled this into branch issue/8 and updated to the E::ts notation. Could you confirm that it works? If so, I'll pull into master and make a release.

Detsieber commented 2 years ago

Hi Björn,

line 140 will not work:

// CRM_Utils_SepaOptionGroupTools::checkRecurringFrequencyUniE::ts(TRUE, TRUE);

And should stay as it was:

  // CRM_Utils_SepaOptionGroupTools::checkRecurringFrequencyUnits(TRUE, TRUE);

Apart of that, I will test ASAP.

Best Detlev

Am 18.10.21 um 09:20 schrieb Björn Endres:

Thanks @Detsieber https://github.com/Detsieber. I have pulled this into branch |issue/8| and updated to the |E::ts| notation. Could you confirm that it works? If so, I'll pull into master and make a release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Project60/org.project60.sepapp/pull/8#issuecomment-945437231, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABL55H7OZTH7QKAUHV763KLUHPDE7ANCNFSM5GCAPPDQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bjendres commented 2 years ago

Yes, thanks, good catch - I fixed that.

It didn't show up in my mini-test, since that line was commented out anyway.

Let me know what your tests say.