ProjectAlita / projectalita.github.io

Langing
GNU Affero General Public License v3.0
1 stars 1 forks source link

[BUG] Save and Discard Buttons Activated After Executing Search Function in Datasources #495

Closed epamLDadayan closed 1 month ago

epamLDadayan commented 1 month ago

Description: The Save and Discard buttons become activated and available for clicking after executing the Search function in datasources. These buttons should not be activated or available for clicking after performing a search.

Steps to Reproduce:

  1. Create a datasource.
  2. Create and set up a dataset.
  3. Navigate to the Search tab.
  4. Select the corresponding embedding model.
  5. Enter the text and start the search.
  6. Verify whether the Save and Discard buttons become active and available for clicking.

Actual Result: The Save and Discard buttons are activated and become available for clicking after executing the Search function.

Expected Result: The Save and Discard buttons should not be activated or available for clicking after executing the Search function.

Notes:

HawkQing1 commented 1 month ago

@epamLDadayan , Hi Levon, the Save and Discard Buttons are activated due to the user selects/changes embedding modal, should we not save this changes in datasource details?

epamLDadayan commented 1 month ago

@HawkQing1 , Let's review it together.

epamLDadayan commented 1 month ago

Fixed thanks to other changes and fixes.