search

ProjectBorealis / PBSync

System for syncing Unreal Engine project git repositories
MIT License
79 stars 8 forks source link

build,pbsync: various tweaks to make the tool run on Linux #15

Closed commodo closed 3 years ago

commodo commented 3 years ago

Hey,

While trying to figure out how to build the game from source, I tried to use the PBSync tool to see what it does. After I while I think I figure out partially how to use it [without any docs].

Trying to run this on a Linux machine, this is where I got to, before hitting a dead-end. Maybe will continue on Discord to get any hints [if possible].

Note: the Signed-off-by tag is a habit; most open-source projects require it as a form of legalese; I can remove it if necessary.

Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com

mastercoms commented 3 years ago

Thanks for the catch about sequence vs. strings for shell execution. We had to enable shell on Windows or else git & friends wouldn't be found on path. So we just enabled it without seeing the other side effects to other args.

As for the GCM stuff, that's required. I just hadn't updated the Base-Project PBSync.xml yet, but I have now, for your convenience. Usually we do not include backwards compatibility, and expect old projects to upgrade to accommodate changes in PBSync.

Finally, I don't mind the sign-off tag.

Thank you for the work so far, really appreciate it! I would be happy to assist in your endeavors, either on Discord or here.

commodo commented 3 years ago

As for the GCM stuff, that's required. I just hadn't updated the Base-Project PBSync.xml yet, but I have now, for your convenience. Usually we do not include backwards compatibility, and expect old projects to upgrade to accommodate changes in PBSync.

ack will drop that commit thanks for the quick fix; maybe, i'll change it to checking which attribute is missing and report that; getting a 'NoneType' has no 'text' attribute error requires some debugging;

commodo commented 3 years ago

Thanks for the catch about sequence vs. strings for shell execution. We had to enable shell on Windows or else git & friends wouldn't be found on path. So we just enabled it without seeing the other side effects to other args.

I think this is very dependent on the environment that you use [normal Windows, MinGW, MSYS, etc?]. Technically if you ensure that the PATH env var is fine git & friends should be found-able. But I do remember, that on Windows, Git is usually (or used to be) deployed packaged with some sort of MinGW/MSYS environment which has some Linux-like bash on top of Windows. So, it becomes a bit quirky.

commodo commented 3 years ago

on a side note; i'm also waiting for this to get through: https://github.com/GoogleCloudPlatform/gsutil/pull/1174 after that the note about manually patching gsutil should go away -> simpler life

commodo commented 3 years ago

Changelog v1 -> v2: