search

ProjectBorealis / UEGitPlugin

Unreal Engine Git Source Control Plugin (refactored)
MIT License
512 stars 104 forks source link

Changed `GetMissingVsExistingFiles` to force update the state from the Provider. #166

Closed geekrelief closed 4 months ago

geekrelief commented 4 months ago

Reverting an asset wasn't unlocking the files 100% of the time. Sometimes GetMissingVsExistingFiles would return empty and there would be nothing to revert or unlock.

mastercoms commented 4 months ago

Hi, thanks for the contribution! Wouldn't it be better to fix the caching issue in the first place?

geekrelief commented 4 months ago

Actually, this doesn't seem to work properly in further testing. I'm not sure why it's not working now. It was in early tests.

Yes I agree it'd be ideal to fix the caching issue, but I'm still familiarizing myself with the code based as well as Unreal's source ontrol module. I'm going to withdraw the pull request until I can at least make sure the revert 100% always unlocks the file.

I'm still trying to understand or find out a way to unlock a file even if it has no changes it and the context menu doesn't even have the option to Revert. Only Revert Writable Files is enabled, and it doesn't unlock the file.

mastercoms commented 4 months ago

Do you know if your LFS username is set correctly?