ProjectDrawdown / global-research-platform

Drawdown Global Research Platform - UI
Other
20 stars 19 forks source link

Workbook view/edit not scrollable to view/select all sectors & clusters #133

Open shrutimehta13 opened 2 years ago

shrutimehta13 commented 2 years ago
  1. Create a New workbook
  2. Observe Portfolio selection > page is scrollable and all visible
Screenshot 2021-11-22 at 6 37 44 PM
  1. Save selection
  2. now observe workbook page or choose to ediT

Observed: No scrollbar

Screenshot 2021-11-22 at 6 37 00 PM
shrutimehta13 commented 2 years ago

related to ProjectDrawdown/open-collaboratory#123

colleenskemp commented 2 years ago

@shrutimehta13 - I've walked through this and see that only the selected solutions are shown after save. This is expected and confirmed in the designs. https://www.figma.com/file/QImAyi1guE4AICGMN7uODK/Drawdown-Portfolio-UI---%5BFigma-Chakra-UI%5D?node-id=1971%3A122156

If I understood your feedback correctly, will you please close this ticket?

If I didn't fully understand the issue described, please let me know. Thank you!

eethann commented 2 years ago

I believe this ticket should be in the Global Research Platform project and not the Open Collaboratory project

eethann commented 2 years ago

Confirmed that this is an error.

shrutimehta13 commented 2 years ago

@colleenskemp issue is after saving a workbook, we are not able to add/remove solutions as the page is not scrollable and hence not selectable by user. This is a Must Fix.

colleenskemp commented 2 years ago

Okay - I think this was a regression. @sutjin - will you please take a look?

shrutimehta13 commented 2 years ago

tested here https://stage.pdd.colab.coop/ [Edit portfolio] with existing and new workbooks and it does not work still.

sutjin commented 2 years ago

weird, let me try to redeploy and see what's going on

sutjin commented 2 years ago

redeploying seems to fixed it, please double check :)

shrutimehta13 commented 2 years ago

fixed