ProjectDrawdown / global-research-platform

Drawdown Global Research Platform - UI
Other
20 stars 19 forks source link

Implementing Tourguide for issue #28 #95

Closed Chukslord1 closed 3 years ago

litenull commented 3 years ago

This looks good in general.

Some comments:

  1. Why do we need sass if we have styled components?
  2. Put default values in variables instead of hard coding
sutjin commented 3 years ago

Overall looks good, a bit of a nitpick - would prefer if we use ID instead of class since we want to ensure the components going on tour is unique, but this one works too

Chukslord1 commented 3 years ago

@litenull @sutjin Please review. I think this pull request is ready for merging