search

ProjectDrawdown / solutions

The mission of Project Drawdown is to help the world reach “Drawdown”— the point in the future when levels of greenhouse gases in the atmosphere stop climbing and start to steadily decline, thereby stopping catastrophic climate change — as quickly, safely, and equitably as possible.
https://www.drawdown.org/
Other
211 stars 91 forks source link

Potential fix for multiple test failures related to HelperTables #448

Closed danielmk closed 2 years ago

danielmk commented 2 years ago

This PR relates to #317 where we've been trying to find a fix for multiple, possibly related testing failures.

I found that for the composting solution, adding copy_pds_datapoint=False to the definition of HelperTables solves the testing failure.

I also believe that the same change should be bikeinfrastructure & buildingautomation It fixes the current cause for testing failure but then another testing failure occurs.

I will check how this small change affects the other problematic solutions discussed in the issue and report as soon as I think this PR is ready for merge.

denised commented 2 years ago

Good to see progress!

danielmk commented 2 years ago

This specific copy_pds_datapoint=False fix solved testing failures for composting and walkablecities.

In bikeinfrastructure it solves an issue but testing still fails because of another unrelated problem.

In the other scenarios I tried it on it either changes nothing or makes things worse.

I suggest merging this PR since the other solutions will probably require different types of fixes.

denised commented 2 years ago

Got it --- thanks!