denised
commented
2 years ago Is this intended to be a temporary or a permanent change?
If it is a permanent change, the approach should be to write out an updated Scenario (a scenario and an AC have a 1:1 relationship; the scenario is basically a code wapper around an AC instance). Then after that, you would request the user to restart their python process, so the new (integration version) scenario would be loaded instead.
If it is a temporary change, this is interesting, but I believe I know how to do it. The reason for having AC (and effectively scenario) be a frozen class is probably because the actual identity (object id) are used as cache keys for lots and lots of computed results. So what you would want to do is: (a) Use the ac.as_dict() procedure to create a plain dictionary with all the AC keys in it. (b) Update the key(s) you need in that dictionary. (c) Use load_scenario with this dict as a 2nd argument to create a brand new scenario instance with the changed AC.
If this is more than a one-off situation, then that 2nd process seems like a good candidate for integration_base.py
-- Denise Draper @.***
On Fri, Sep 24, 2021, at 12:38 AM, Daniel Müller-Komorowska wrote:
The logic of building integration (#418 https://github.com/ProjectDrawdown/solutions/issues/418) is such that we calculate integrated parameters (efficiency factors and such) and then feed those to the solution before calculating.
I would therefore need to input those integrated parameters into their correct place in
AdvancedControls. However, AdvancedControls is a frozen dataclass, therefore I getFrozenInstanceError: cannot assign to field 'soln_energy_efficiency_factor'when I try to assign to an attribute of AdvancedControls.Could we unfreeze AdvancedControls @denised https://github.com/denised ?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/issues/465, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAMTSIQXWSZADCKVKTRHTUDQTIDANCNFSM5EVK2YOA.
danielmk
The logic of building integration (#418) is such that we calculate integrated parameters (efficiency factors and such) and then feed those to the solution before calculating.
I would therefore need to input those integrated parameters into their correct place in
AdvancedControls. However, AdvancedControls is a frozen dataclass, therefore I getFrozenInstanceError: cannot assign to field 'soln_energy_efficiency_factor'when I try to assign to an attribute of AdvancedControls.Could we unfreeze AdvancedControls @denised ?