ProjectDrawdown / solutions

The mission of Project Drawdown is to help the world reach “Drawdown”— the point in the future when levels of greenhouse gases in the atmosphere stop climbing and start to steadily decline, thereby stopping catastrophic climate change — as quickly, safely, and equitably as possible.
https://www.drawdown.org/
Other
211 stars 91 forks source link

bug fix Scenario class #508

Closed denised closed 2 years ago

denised commented 2 years ago

class Scenario has shared class variables that become instance variables when overridden --- but only if you override them. If you modify them instead, you modify the class variable which then affects all other instances as well. In this case, it meant that overridden adoption parameters became permanent, and affected subsequent instantiated scenarios. Detected because walkablecities passed tests by itself, but failed when tested together with other solutions. I'm amazed that there weren't more issues.

Also deleted a bunch of overrides that were just re-affirming the default value.