search

ProjectDrawdown / solutions

The mission of Project Drawdown is to help the world reach “Drawdown”— the point in the future when levels of greenhouse gases in the atmosphere stop climbing and start to steadily decline, thereby stopping catastrophic climate change — as quickly, safely, and equitably as possible.
https://www.drawdown.org/
Other
211 stars 91 forks source link

Why are there both new_scenario and ocean_scenario classes? #520

Closed denised closed 2 years ago

denised commented 2 years ago

Seems like we should need just one of these... @glass-wing, it looks like ocean_scenario is the code in use. Does any of your code actually use new_scenario.py?

glass-wing commented 2 years ago

Hi Denise.

Happy new year! I'm going to pick this up again on Monday. Haven't looked at it in over a month now. Lots of cobwebs. Hope you're well.

Rgds Neil

On Fri, 21 Jan 2022 at 15:28, Denise Draper @.***> wrote:

Seems like we should need just one of these... @glass-wing https://github.com/glass-wing, it looks like ocean_scenario is the code in use. Does any of your code actually use new_scenario.py?

— Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/issues/520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATGKQ2F34OHATL5XSQTDIYDUXD4JDANCNFSM5MOV2Z5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

glass-wing commented 2 years ago

You're right - ocean_scenario is the only one I use. I did a search across all files in my fork, and found no matches.

Rgds Neil

On Fri, 21 Jan 2022 at 15:28, Denise Draper @.***> wrote:

Seems like we should need just one of these... @glass-wing https://github.com/glass-wing, it looks like ocean_scenario is the code in use. Does any of your code actually use new_scenario.py?

— Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/issues/520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATGKQ2F34OHATL5XSQTDIYDUXD4JDANCNFSM5MOV2Z5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

denised commented 2 years ago

OK then, I will remove it --- thanks for checking.

denised commented 2 years ago

done