search

ProjectDrawdown / solutions

The mission of Project Drawdown is to help the world reach “Drawdown”— the point in the future when levels of greenhouse gases in the atmosphere stop climbing and start to steadily decline, thereby stopping catastrophic climate change — as quickly, safely, and equitably as possible.
https://www.drawdown.org/
Other
216 stars 91 forks source link

Large-scale simplification. #532

Closed glass-wing closed 2 years ago

glass-wing commented 2 years ago

Rewrote loops to use vectorised operations and simplified.

denised commented 2 years ago

Fantastic to see @glass-wing ! Could you do me a favor and do a final merge with develop?

glass-wing commented 2 years ago

Thanks! Not sure what you mean by a final merge though. The PR needs your review/approval to complete.

N.

On Mon, 25 Apr 2022 at 06:21, Denise Draper @.***> wrote:

Fantastic to see @glass-wing https://github.com/glass-wing ! Could you do me a favor and do a final merge with develop?

— Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/pull/532#issuecomment-1107920836, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATGKQ2E73IGN3ASCAC5MV5TVGW3N7ANCNFSM5UBFHABQ . You are receiving this because you were mentioned.Message ID: @.***>

denised commented 2 years ago

Could you please do a merge from the develop branch of the repo, and fix any merge conflicts (if any occur) that result — thanks. (You’ve got two merge commits in the pull request already, but the last was in November I think, and there have been code changes since)

-- Denise Draper @.***

On Sun, Apr 24, 2022, at 11:39 PM, Neil Lyons wrote:

Thanks! Not sure what you mean by a final merge though. The PR needs your review/approval to complete.

N.

On Mon, 25 Apr 2022 at 06:21, Denise Draper @.***> wrote:

Fantastic to see @glass-wing https://github.com/glass-wing ! Could you do me a favor and do a final merge with develop?

— Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/pull/532#issuecomment-1107920836, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATGKQ2E73IGN3ASCAC5MV5TVGW3N7ANCNFSM5UBFHABQ . You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/pull/532#issuecomment-1108135138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAMTTRQRVE2M3K3ZET3BTVGY43TANCNFSM5UBFHABQ. You are receiving this because you were assigned.Message ID: @.***>

glass-wing commented 2 years ago

ok got it - I've refreshed my personal fork with the latest code changes from the main repo. No merge conflicts. Looks good now?

denised commented 2 years ago

Great to see this in :-)