This is a more aggressive change, so if we don't merge it that's fine.
Add guards instead of large else blocks
Add functions for god/don combines.
Return true on combine success, fail on fail inside functions
Originally I was adding a check for god/don combines on top, if the expansion is enabled, however, I think for this to properly work, we should fail the combine as well on attempt out of era. This way you don't miss a flag or other event triggers.
I can add the combine reject if you do certain recipes when out of era, this is a good prevention for TLP reasons where someone is trying to do a combine prior to expansion release.
But the baseline this PR adds, is still likely useful for foundation
xackery
commented
2 months ago
This is a more aggressive change, so if we don't merge it that's fine.
Add guards instead of large else blocks
Add functions for god/don combines.
Return true on combine success, fail on fail inside functions
Originally I was adding a check for god/don combines on top, if the expansion is enabled, however, I think for this to properly work, we should fail the combine as well on attempt out of era. This way you don't miss a flag or other event triggers.
I can add the combine reject if you do certain recipes when out of era, this is a good prevention for TLP reasons where someone is trying to do a combine prior to expansion release.
But the baseline this PR adds, is still likely useful for foundation