Closed DevLab2425 closed 4 months ago
Now that #1190 has been merged, I would rebase this branch against master to help clear up any related test failures.
Had a little time to circle back on this and was able to rebase and get all the test cases passing along with updating any Rollup dependencies used in our other packages.
There does seem to be one issue though, in that a production build of the website is missing a script file reference for the Get Started button on the home page and a 404 on the script asset (though interestingly there is a 756510913.js in the .greenwood/ folder, where assets are collected prior to final bundling 🤔 )
As opposed to what it should look like
Will see if there is anything of note in the Rollup v3 changelog and start taking a look, but we're almost this almost there!
Got if fixed, I think duplicate imports of the <eve-container>
custom element definition may have been throwing things off, possibly being treated as side effects. Will see if I can gather more conclusive proof, but surprised we actually didn't custom element registries with the previous implementation. 😬
Related Issue
Fix: #1087
Summary of Changes
yarn upgrade
forrollup
in the CLI@rollup/
packages supportrollup@3.x.x
. Ayarn upgrade
was run, but there was no impact to the current lockfile for those dependencies.~TODO