ProjectEvergreen / greenwood

Greenwood is your full-stack workbench for the web, focused on supporting modern web standards and development to help you create your next project.
https://www.greenwoodjs.io
MIT License
95 stars 9 forks source link

enhancement/Issue-1087: Upgrade Rollup to latest 3.x.x #1187

Closed DevLab2425 closed 4 months ago

DevLab2425 commented 7 months ago

Related Issue

Fix: #1087

Summary of Changes

  1. Ran yarn upgrade for rollup in the CLI
    • ~The collection of @rollup/ packages support rollup@3.x.x. A yarn upgrade was run, but there was no impact to the current lockfile for those dependencies.~
    • After a deeper dive, each of the plugins does have a version greater than the version listed, which was initially overlooked. A dedicated upgrade was done to the latest major.
  2. Upgrade all Rollup dependencies in plugins
  3. Update test cases as needed (mainly for updated file name hashes)

TODO

  1. [x] Fix home page Get Started button not working - https://github.com/ProjectEvergreen/greenwood/pull/1187#issuecomment-1947673126
thescientist13 commented 6 months ago

Now that #1190 has been merged, I would rebase this branch against master to help clear up any related test failures.

thescientist13 commented 5 months ago

Had a little time to circle back on this and was able to rebase and get all the test cases passing along with updating any Rollup dependencies used in our other packages.

There does seem to be one issue though, in that a production build of the website is missing a script file reference for the Get Started button on the home page and a 404 on the script asset (though interestingly there is a 756510913.js in the .greenwood/ folder, where assets are collected prior to final bundling 🤔 )

Screenshot 2024-02-15 at 9 41 04 PM

As opposed to what it should look like Screenshot 2024-02-15 at 9 06 38 PM

Will see if there is anything of note in the Rollup v3 changelog and start taking a look, but we're almost this almost there!

thescientist13 commented 5 months ago

Got if fixed, I think duplicate imports of the <eve-container> custom element definition may have been throwing things off, possibly being treated as side effects. Will see if I can gather more conclusive proof, but surprised we actually didn't custom element registries with the previous implementation. 😬 Screenshot 2024-02-15 at 9 58 26 PM