search

ProjectEvergreen / greenwood

Greenwood is your workbench for the web, embracing web standards from the ground up to empower your stack from front to back.
https://greenwoodjs.dev
MIT License
101 stars 10 forks source link

Import Attributes support in Acorn #1218

Open thescientist13 opened 7 months ago

thescientist13 commented 7 months ago

Summary

Playing the long game a bit, but as Import Attributes are only currently Stage 3, it is not supported in some key dependencies yet, like acorn. (made a little repro repo to confirm)

However, it is supported in NodeJS and browsers as was implemented in #923 and https://github.com/ProjectEvergreen/wcc/pull/157.

Will also want to track this along with an upgrade to latest Rollup, which actually took out the ability to pass in custom Acorn plugins - https://github.com/ProjectEvergreen/greenwood/issues/1087#issuecomment-1947621572

Details

As part of those PRs for Greenwood and WCC, a community plugin was used to bridge the gap, however when the spec graduates to Stage 4 and / or acorn adopts it, we can / should (for both WCC and Greenwood):

  1. [ ] Upgrade acorn version
  2. [ ] Will probably need to rollback custom parser changes
  3. [ ] Remove the dependency on acorn-import-attributes
thescientist13 commented 3 weeks ago

Seems like this might be available now! https://github.com/acornjs/acorn/blob/master/acorn/CHANGELOG.md#8140-2024-10-27