bug/issue 1223 handle incorrect nested SSR page bundle output name mapping - Githubissues

ProjectEvergreen / greenwood

Greenwood is your full-stack workbench for the web, focused on supporting modern web standards and development to help you create your next project.

https://www.greenwoodjs.io

MIT License

94 stars 9 forks source link

bug/issue 1223 handle incorrect nested SSR page bundle output name mapping #1224

Closed thescientist13 closed 2 months ago

thescientist13 commented 2 months ago

Related Issue

resolves #1223

Summary of Changes

Map SSR page output paths and bundle names to Rollup bundle names
Added relativeWorkspacePagePath as convenience to the graph for each page, should track as part of #1167
Incorporated this change to handle a change in behavior in latest Node 18.20.x

Will make to align with work being done in https://github.com/ProjectEvergreen/greenwood/pull/1212

TODO

[x] fix windows build failures
[x] Phantom _.greenwood/__ directory?
[x] Downstream testing
- https://github.com/AnalogStudiosRI/www.blissri.com/pull/21/commits/f0f0fe444396a710a8376dfe0c28f25c4adf81ae
- https://66356e162788c46b161f40ab--thriving-kataifi-2b287f.netlify.app/photos/blissfest-2023/
[x] Create an enhancement issue for making sure we have better control over output map naming - https://github.com/ProjectEvergreen/greenwood/issues/1226

Main issue was with very loose enforcement of output naming, such that when running this sort of pages through Rollup

src/
  pages/
    blog/
      index.js
    index.js

Both of those will come out of the same name to Rollup, and because they will be duplicates, you'll be getting unexpected names, like

_index.js
_index2.js
_index3.js
...

So the main fix here is to map our bundle names to whatever Rollup spits out for now just keep things working and in sync.