ProjectEvergreen / greenwood

Greenwood is your full-stack workbench for the web, focused on supporting modern web standards and development to help you create your next project.
https://www.greenwoodjs.io
MIT License
94 stars 9 forks source link

enhancement/general improvements and fixes for custom resource plugin integrations #1234

Closed thescientist13 closed 2 weeks ago

thescientist13 commented 1 month ago

Related Issue

In support of #1233 , and based on testing in https://github.com/ProjectEvergreen/www.greenwoodjs.dev/pull/11, found some general improvements and fixes for custom resource plugin integrations into Greenwood around making plugins better able to play nicely together.

This a pre-cursor to #1233 to validate the core changes first outside of the plugin PR.

Summary of Changes

  1. Enable resolve lifecycle into custom loaders
  2. Enable resolve lifecycle into rollup configuration
  3. Remove break statement from serve command, since it would "bail" after an initial match

TODO

Make sure to sanity test these against the greenwoodjs.dev website

  1. [x] Try and restore / understand resource-utils.js changes
  2. [x] See if the 'js` check in rollup.config.js can be removed - we shouldn't and it will break, just Rollup deal with JS files
  3. [x] Clean up resolve filters in loaders.js
  4. [x] clean up console logs / commented code