ProjectEvergreen / greenwood

Greenwood is your workbench for the web, embracing web standards from the ground up to empower your stack from front to back.
https://www.greenwoodjs.io
MIT License
96 stars 9 forks source link

inline optimization should inline everything #652

Open thescientist13 opened 3 years ago

thescientist13 commented 3 years ago

Type of Change

Summary

Noticed in https://github.com/ProjectEvergreen/greenwood/pull/642#issuecomment-874788275 that we have an opportunity to make inline optimization setting more aggressive.

Details

For example, in one of our specs, when we import from _nodemodules, that code itself is not inlined.

Before

import { html } from 'lit-html';
import { LitElement } from 'lit-element';

After

import"/lit-html.d69ea26f.js";import"/lit-element.ea26fec7.js";//# sourceMappingURL=1832243663-scratch.01361a49.js.map

To be truly inline so as not to initiate ANY network requests, we would want all of that _nodemodules code inlined too.


maybe at this time we could review renaming scratch to something more meaningful?

thescientist13 commented 10 months ago

Not sure if this is actually still an issue, but would be good to confirm so we can cross it off the list.