thescientist13
commented
3 years ago OMG, I just realized we might be able to completely bypass this by just using having all plugin authors just use relative paths in their templates!? 🤦
So instead of hardcoding node_modules path like this like we are documenting now
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="/node_modules/greenwood-starter-presentation/dist/styles/theme.css"></link>
<link rel="stylesheet" href="/node_modules/greenwood-starter-presentation/dist/styles/main.css"></link>
</head>
<body>
<content-outlet></content-outlet>
</body>
</html>to just this!
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="../styles/theme.css"></link>
<link rel="stylesheet" href="../styles/main.css"></link>
</head>
<body>
<content-outlet></content-outlet>
</body>
</html>that should work anywhere as long as you just copy the directory structure to node modules. This means that we should then be able to completely remove the need for all of the issues here - #682
- Having to use a development only Resource plugin
- Needing to detect installation of the plugin to determine where the template location is
🤞
Type of Change
Summary
Bit of a fail on my end, but although I added test cases for developing and building a Greenwood project when consuming a Theme Pack, I didn't actually properly test the perspective of a user a publishing / producing a theme pack with Greenwood. And so although parts of the Theme Pack guide still apply for development at least, trying to run
greenwood build | servefails because (naturally) Rollup is going to find the paths the paths in HTML to node modules in the developer's repository.FWIW
greenwood developworks just fine, and I still need to test with publishing, so will see if there is a need for any updates on that as well, and add them here.For now, will mark
v0.15.0release as a pre-release for now.Details
So in this reference repo, when I run
greenwood buildon that branch, Rollup is unhappyBasically, just like we suggest creating a resource for development, we're going to need to do something similar in our rollup code to see if any user plugins can resolve it? Ideally would like to find a way to have this only be a local development workaround. Maybe an agreed upon rollup plugin that users can drop into their development environment?
Maybe some future thoughts for https://github.com/ProjectEvergreen/greenwood/discussions/682
Should also add some tests to cover this persona in our test cases; someone building a Greenwood plugin_