search

ProjectIgnis / CardScripts

Project Ignis card script libraries and canonical card scripts for EDOPro. Send bug reports through Discord only!
86 stars 60 forks source link

Updated RegisterEffect for Valmonica effects #1071

Closed EerieCode closed 1 year ago

EerieCode commented 1 year ago

Added extra constants for the effects of Valmonica cards that start by dealing damage or recovering LP (registration required for the effects of "Angelo Valmonica" and "Demone Valmonica"). These constants will need to be added to the constants file before merging. I've also left the effect codes as constants instead of the numbers used for everything else: not sure if we'll end up setting them as those cards' IDs anyway, but I think it'd be better to have them as constants? Feels a bit cleaner and better for futureproofing.

Additionally, I moved the function that keeps track of the matches between registration flags and effect code to its own function instead of leaving it inside RegisterEffect, in order to keep the function cleaner.

pyrQ commented 1 year ago

After some internal discussion we ended up deciding to go with a different approach.