Fix "Chain Destruction"

[XGlitchy30]

The Normal Trap "Chain Destruction", which reads...

When a monster(s) with 2000 or less ATK is Summoned: Target 1 of them; destroy all cards with that name in its controller's hand and Main Deck. ...currently has the following issues:

• At the time of resolution, if the target left the Monster Zone between the activation and resolution of "Chain Destruction", or if it is currently in face-down Defense Position, the effect of "Chain Destruction" still destroys any available card in the hand and Main Deck of the controller, even though it shouldn't be able to. (Link to the FAQ on the Konami DB, refer to the last bulleted entry: https://www.db.yugioh-card.com/yugiohdb/faq_search.action?ope=4&cid=4813)
• When a Fusion, Synchro, Xyz, or Link Monster is Summoned, "Chain Destruction" should not be able to be activated, unless that monster has a name of a card that can be placed in hand/Main Deck. (Link to the translated Q&A on the YGOrganization DB: https://db.ygorganization.com/qa#13158)

The following link redirects to the bug report in the official_card_rulings_bugs channel of the ProjectIgnis Discord server, where relevant replays reproducing the bugs can be found: https://discord.com/channels/170601678658076672/184324960842416129/1231661707332423761

The first problem was fixed by invoking the Card.IsRelateToEffect and Card.IsFaceup functions at the beginning of the Operation Function.

The second problem was more complex and prompted several changes regarding activation legality:

• If the Summoned monster is controlled by the activator of "Chain Destruction", then I made it so it can be targeted only if there exists a card with its same name in the activator's hand and/or Main Deck. Therefore, a Duel.IsExistingMatchingCard call was added to the filter.
• If the Summoned monster is controlled by the opponent of the activator, then it can be targeted only if it has a name of a card that can be placed in the hand and/or Main Deck. To check this property, the script spawns a hidden Token as soon as it is allowed to once the Duel starts: while the filter is being ran, for each of the names the Summoned monster has, this Token is transformed into the card that has that original name; if the Token's card type is still TYPE_TOKEN or if it is still an Extra Deck Monster, then it means that the name is not eligible for the activation of "Chain Destruction". The check is passed as soon as 1 eligible name is found. This procedure is defined by the s.mdnamecheck function inside the script. This procedure is followed if the opponent Summons a Fusion, Synchro, Xyz or Link Monster, following what was stated in the Q&A: I also made it so the names are checked even if Tokens are Summoned by the opponent, and if the monster they Summon is affected by an EFFECT_CHANGE_CODE effect (to future-proof the case of Main Deck monsters taking the name of a card that cannot be found in the hand/Main Deck).

Additionally, missing Operation Info functions were added in the Target Function:

• If the targeted monster is controlled by the activator, the script invokes Duel.SetOperationInfo

• If the targeted monster is controlled by the opponent, the script invokes Duel.SetOperationInfo only if there exist public cards in the hand and/or Main Deck of the opponent (either because they are revealed in the hand, or because they are face-up in the Deck due to "Convulsion of Nature"). Otherwise, the script invokes Duel.SetPossibleOperationInfo.

• [x] I am following the contributing guidelines.

• [x] I am making the changes to modernize the scripts.

[pyrQ]

Should be able to use the Duel.GetCardTypeFromCode function instead of all that hidden Token stuff. See the documentation here: https://projectignis.github.io/scrapi-book/api/functions/Duel/GetCardTypeFromCode.html

[XGlitchy30]

Fixed the following issues:

• Replace the Token procedure with another one that uses Duel.GetCardTypeFromCode
• Added an additional check with Duel.GetFieldGroupCount that prevents "Chain Destruction" from being activated by targeting a monster controlled by the opponent if they have no cards in their hand and Main Deck

[ClaireStanfield]

I'm not sure if this is considered improper etiquette but, since the card is being worked on, I figured I'd bring to attention here another issue with this card I reported a while back that will persist even with these changes.

The card can still be activated and will properly resolve even if the Summoned monster leaves the field before the card's activation window. Here's a puzzle code to demonstrate what I mean by summoning Reptilianne Servant.

--Created using senpaizuri's Puzzle Maker (updated by Naim & Larry126)
--Partially rewritten by edo9300
Debug.ReloadFieldBegin(DUEL_ATTACK_FIRST_TURN+DUEL_SIMPLE_AI,5)
Debug.SetPlayerInfo(0,8000,0,0)
Debug.SetPlayerInfo(1,8000,0,0)

--Main Deck (yours)
Debug.AddCard(16008155,0,0,LOCATION_DECK,0,POS_FACEDOWN)

--Hand (yours)
Debug.AddCard(16008155,0,0,LOCATION_HAND,0,POS_FACEDOWN)

--Monster Zones (yours)
Debug.AddCard(79491903,0,0,LOCATION_MZONE,2,POS_FACEUP_ATTACK,true)

--Spell & Trap Zones (yours)
Debug.AddCard(1248895,0,0,LOCATION_SZONE,2,POS_FACEDOWN)

Debug.ReloadFieldEnd()
aux.BeginPuzzle()

[XGlitchy30]

I'm not sure if this is considered improper etiquette but, since the card is being worked on, I figured I'd bring to attention here another issue with this card I reported a while back that will persist even with these changes.

The card can still be activated and will properly resolve even if the Summoned monster leaves the field before the card's activation window. Here's a puzzle code to demonstrate what I mean by summoning Reptilianne Servant.

--Created using senpaizuri's Puzzle Maker (updated by Naim & Larry126)
--Partially rewritten by edo9300
Debug.ReloadFieldBegin(DUEL_ATTACK_FIRST_TURN+DUEL_SIMPLE_AI,5)
Debug.SetPlayerInfo(0,8000,0,0)
Debug.SetPlayerInfo(1,8000,0,0)

--Main Deck (yours)
Debug.AddCard(16008155,0,0,LOCATION_DECK,0,POS_FACEDOWN)

--Hand (yours)
Debug.AddCard(16008155,0,0,LOCATION_HAND,0,POS_FACEDOWN)

--Monster Zones (yours)
Debug.AddCard(79491903,0,0,LOCATION_MZONE,2,POS_FACEUP_ATTACK,true)

--Spell & Trap Zones (yours)
Debug.AddCard(1248895,0,0,LOCATION_SZONE,2,POS_FACEDOWN)

Debug.ReloadFieldEnd()
aux.BeginPuzzle()

It's a bit late here so I pushed a quick fix to address this issue. I am fairly sure a simple check with Card.IsLocation in the filter should be enough for a "When" effect, but if that proves to be insufficient, I'll work out something else tomorrow once I can dedicate enough time to it.