Open NaimSantos opened 4 years ago
Does Witch's Strike have proper core support now, or is it still using a workaround from Percy?
It has already proper support, But i tested both our version and fluo's version of the script and the interaction is wrong in both, with and without the suggested and not Duel.CheckEvent(EVENT_SUMMON)
.
As a suggestion, perhaps in Witch's Strike's normal condition, when it detects a negated summon, it needs to set a flag (which resets at an appropriate time) instead of activating, and then it has a trigger effect for the correct timing event, with a condition of having that flag set.
Ruling/scenario that might be relevant, to make sure that Witch's Strike works correctly in general when it comes to such a scenario.
Player A CL1 "Yosenju Kama 1" Player B CL2 "Solemn Strike" Player A CL3 "Solemn Judgment" Chain resolves, player B has "Cosmic Blazar Dragon", "Horn of Heaven" and "Witch's Strike".
- If player B uses "Horn of Heaven", they can activate "Witch's Strike" after "Horn of Heaven" resolves.
- If player B uses "Cosmic Blazar Dragon", they cannot chain "Witch's Strike", but they can activate it immediately after the chain resolves.
- If player B does not negate the summon, they can use "Witch's Strike" in response to it ("Bottomless Trap Hole" timing).
I've added a puzzle based on the above scenario as "Test 60-2" in https://github.com/kevinlul/edopro-config/commit/a9a2eea3c817b7d44d8ba52fe6b21f1998ac81f7
Is this fluo change related? https://github.com/Fluorohydride/ygopro-core/commit/7f2b6ccb142667b4ff19ca267221a582ec4be603
Puzzle 60-2 results in a game crash when Horn of Heaven is activated by the AI. Incorrect interaction remains in puzzle 60.
The incorrect interaction in puzzle 60 also exists in other simulators. The 60-2 game crash does not exist in other simulators. @edo9300
After importing the fix from FH, the following happened in puzzle 60, which I think is now correct: Normal Summon Kama 1, activate Kama 1 effect. Chain Vampire Domination, Chain Yosenju's Secret Move. Move resolves, negating Domination, allowing 1 to resolve. Yosen Training Grounds gains a counter, Torrential Tribute can activate but I pass, Witch's Strike can activate.
The crash in 60-2 still exists, which makes it impossible to test the other scenarios listed.
The crash occurs in the exact same place as in issue #38 (https://github.com/kevinlul/edopro-script/issues/38#issuecomment-591228569) with SelectUnselect. Since this is not in other simulators, it's an effect of our ocgcore implementation then @edo9300
SIMPLE_AI Horn of Heaven crash fixed with edo9300/ygopro-core@56cb13e8435c74f8721de0a6692374875f87caa4
Regarding the three scenarios now for 60-2 in TEST_MODE, 1 and 3 are resolved. For 2, you are allowed to chain Witch's Strike to Cosmic Blazar, contrary to what @pyrQ has written.
To reiterate, @edo9300 , the only incorrect interaction occurs in this [puzzle 60-2] for the second interaction that @pyrQ described. In the puzzle, you are allowed to activate Witch's Strike at that timing, which is illegal.