ProjectLam / learn_music_game

Learn heritage instruments with an interactive game with a real instrument
1 stars 2 forks source link

Match List Rework #46

Closed darthLeviN closed 1 year ago

darthLeviN commented 1 year ago

Engine : Godot 4.0 stable Testing: res://test/interactive/test_matches/test_matches.tscn

Possible issues :

darthLeviN commented 1 year ago

for match rejoin The match rejoin is still in the work. this is because :

  • Note seeking hasn't been implemented yet.
  • The 1 on 1 system which is temporary simply includes two people joining and match starts.

I can make an experimental rejoin mechanism right now but it doesn't seem to serve much purpose at the moment. An experimental rejoin mechanism has to wait till there is a lobby room and more settings and controls for a match so that it doesn't have to be redesigned. To resolve the problem i will go for blocking new users into joining in a match when they aren't allowed to.

The current user identification depends on session_id which changes upon rejoin. i added CmdArgs to make it possible to login with a different user quickly for testing purposes.

I'm making writing a patch for the match handling for both godot and the nakama backend. I will include the user id identification for the user list in that patch. The other changes in this patch will be :

After that we can go ahead and make a