ProjectLam / learn_music_game

Learn heritage instruments with an interactive game with a real instrument
1 stars 2 forks source link

Login retry and placeholder for game lobby room. #84

Closed darthLeviN closed 1 year ago

darthLeviN commented 1 year ago

Engine version : https://github.com/ProjectLam/godot-build-scripts/releases/tag/4.0-2c9b534acd-20230502 Nakama backend version index: 1

Major Changes :

A note on godot signals : if a signal takes only 1 parameter, when awaiting for that signal that parameter can be used just like the return value of a function. this is used in the login_set(cancelled) signal in GBackend to know if the login has been cancelled or not.

Things that need to be added on the javascript side: As commented in the GBackend autoload, some features and dialogs need to be added later on. As mentioned in the authenticate_async() function's comments the comments login_set.emit(true) can be used to inform us if the html dialog was closed without setting username and password(or continuing offline was preferred). currently we have automatic login in the non html version so this is still not used there either.

Known issues : Match making scene button focus/keyboard navigation might be messed up a bit right now. will fix that later

TODO on the godot side :