ProjectLibertyLabs / siwf

Sign-In With Frequency: An onboarding app for DSNP/Frequency
https://projectlibertylabs.github.io/siwf/v2/docs
Apache License 2.0
1 stars 0 forks source link

Bug: Example App didn't do anything after completing the login #137

Closed wilwade closed 8 months ago

wilwade commented 8 months ago

Went through the example application, but nothing happened once I completed the sign-in

Steps to reproduce:

  1. Visit https://amplicalabs.github.io/frequency-control-panel/example/ on Firefox
  2. Settings: Rococo, Production, 12, 300, default set
  3. Click "Login with Frequency"
  4. Select Polkadotjs Extension
  5. Select existing MSA with a Handle (Id: 1076 in my case)
  6. Sign delegation
  7. Sign login
  8. Frequency popup goes away
  9. Nothing changes in the UI of Example
  10. Console log shows handshake complete

Description As a developer, I should be able to also see what the response of a payload looks like when going to through the example application.

Acceptance Criteria

enddynayn commented 8 months ago

What are you expecting to happen?

wilwade commented 8 months ago

I guess I was expecting to see something like from the demo video.

https://github.com/AmplicaLabs/frequency-control-panel/blob/main/packages/apps/example/src/routes/%2Bpage.svelte#L138-L149

enddynayn commented 8 months ago

ahh, that works for a development environment. We are not submitting transactions to Rococo. Are you ok with only the encoded transactions being displayed?

wilwade commented 8 months ago

I think that is fine? Something that shows that it did a thing would be good. I'd lead toward a "documentation" type response that helped me understand what comes back in addition to the raw data.

enddynayn commented 8 months ago

Ok, sounds like a feature, not a bug. I'll update it.

JoeCap08055 commented 8 months ago

The example app doesn't have the control keys for any providers on Rococo, so it probably got an RPC error when submitting to the chain. I can update at least to show those errors.

enddynayn commented 8 months ago

closing in favor of #138

JoeCap08055 commented 8 months ago

Reopening; we should at least display an error if we got one when submitting to the chain