ProjectMOSAIC / ggformula

Provides a formula interface to 'ggplot2' graphics.
Other
38 stars 11 forks source link

Properly reexporting functions from `labelled` #160

Closed larmarange closed 1 year ago

larmarange commented 1 year ago

Hi

I'm preparing a new release of the labelled package. https://github.com/larmarange/labelled/issues/139

The function var_label() is introducing new arguments. As this function is copied rather than reexported in ggformula, it is creating inconsistency in the documentation, resulting in a warning when performing rev dep checks, cf. https://github.com/larmarange/labelled/blob/main/revdep/problems.md

To avoid any issue with evolutions of labelled, it would be better to reexports properly the different functions, as proposed in https://github.com/ProjectMOSAIC/ggformula/pull/159

Could you consider merging this pull request and releasing a new version of your package to avoid any problem on CRAN?

Best regards

larmarange commented 1 year ago

@dtkaplan @rpruim Hi

just to inform you that I intend to submit a new version of labelled by the end of the week or early next week.

Regards

rpruim commented 1 year ago

Thanks for the heads up. I haven't had a chance yet to take a look, but I'll see if I can do that in the next couple days.

larmarange commented 1 year ago

thanks

rpruim commented 1 year ago

I plan to submit to CRAN later today. I'm going to see if I can take care of a couple other things at the same time. If not, I'll just do an update to fix this issue.

larmarange commented 1 year ago

Thanks. Ï will postpone the release of labelled for an extra day or two.

nicholasjhorton commented 1 year ago

Thanks to you both for your work on this front.

rpruim commented 1 year ago

We should be all set for labelled to head to CRAN:

Dear maintainer,

thanks, package ggformula_0.10.4.tar.gz is on its way to CRAN.

Best regards,
CRAN teams' auto-check service
larmarange commented 1 year ago

Great. Thanks a lot