ProjectMOSAIC / ggformula

Provides a formula interface to 'ggplot2' graphics.
Other
39 stars 11 forks source link

Dependency on maptools and rgeos #168

Closed olivroy closed 8 months ago

olivroy commented 1 year ago

Do you plan to submit a patch to CRAN before October 16 to avoid archiving the package?

https://github.com/r-spatial/evolution#readme

rpruim commented 11 months ago

It appears that this is only used in dontrun section of an example, so removing this should be fairly easy. I'm hoping to get a new version of the package to CRAN perhaps as soon as today or tomorrow. It is other things that will determine how long this takes.

nicholasjhorton commented 11 months ago

@rpruim many thanks for your work on this front: it's greatly appreciated.

rpruim commented 11 months ago

New example for gf_sf():

suppressPackageStartupMessages(library(ggformula))
example(gf_sf)
#> 
#> gf_sf> if (requireNamespace('maps', quietly = TRUE)) {
#> gf_sf+ library(maps)
#> gf_sf+ world1 <- sf::st_as_sf(map('world', plot = FALSE, fill = TRUE))
#> gf_sf+ gf_sf(data=world1)
#> gf_sf+ 
#> gf_sf+ world2 <- sf::st_transform(
#> gf_sf+   world1,
#> gf_sf+   "+proj=laea +y_0=0 +lon_0=155 +lat_0=-90 +ellps=WGS84 +no_defs"
#> gf_sf+ )
#> gf_sf+ gf_sf(data = world2)
#> gf_sf+ }

Created on 2023-10-16 with reprex v2.0.2

rpruim commented 11 months ago

Improved version. Apparently if(){} blocks intermediate graphical output.

suppressPackageStartupMessages(library(ggformula))
example(gf_sf)
#> 
#> gf_sf> if (requireNamespace('maps', quietly = TRUE)) {
#> gf_sf+   library(maps)
#> gf_sf+   world1 <- sf::st_as_sf(map('world', plot = FALSE, fill = TRUE))
#> gf_sf+   gf_sf(data=world1)
#> gf_sf+ }

#> 
#> gf_sf> if (requireNamespace('maps', quietly = TRUE)) {
#> gf_sf+   world2 <- sf::st_transform(
#> gf_sf+     world1,
#> gf_sf+     "+proj=laea +y_0=0 +lon_0=155 +lat_0=-90 +ellps=WGS84 +no_defs"
#> gf_sf+   )
#> gf_sf+   gf_sf(data = world2)
#> gf_sf+ }

Created on 2023-10-16 with reprex v2.0.2

rsbivand commented 11 months ago

@rpruim rgeos and maptools were archived yesterday, so please do move to submit an updated version of ggformula as soon as possible. See https://github.com/r-spatial/evolution https://r-spatial.github.io/evolution/ for details.

nicholasjhorton commented 11 months ago

Thanks for your note: we are working on the needed updates.

nicholasjhorton commented 11 months ago

@rsbivand thanks again for your efforts to deal with the archived packages. I spoke with @rpruim about removing the dependencies on ggstance from ggformula and mosaic (see #169): we hope to be able to get updated versions of the Mosaic onto CRAN in the near term.