Closed nicholasjhorton closed 5 years ago
I'll have to investigate to see what our options are. I'd suggest a name change if we move away from google as the map provider.
Do you know if google has a different API that we can use?
Thanks for investigating. I was planning to use this in class tomorrow but it's not working sufficiently. (I'm glad I tested!)
This discussion may be relevant: https://stackoverflow.com/questions/50977913/google-maps-shows-for-development-purposes-only
Looks like they are charging for the service now.
Just FYI https://cran.r-project.org/web/packages/RgoogleMaps/index.html has added additional support for open street map tiles.
Rather than try to fix this, here's my plan:
1) Deprecate googleMap()
.
2) Include new leaflet_map() function with similar API that uses leaflet maps. (Note: image below is a static screen shot; leaflet_map()
produces and interactive map that can be zoomed. Clicking on markers shows lat/lon. Clicking on circles displays the radius.)
googleMap(position = rgeo(3))
## Warning message:
## 'googleMap' is deprecated.
## Use 'leaflet_map' instead.
## See help("Deprecated")
leaflet_map(position = rgeo(3), radius = 2, color = "red")
Should we keep the unit for the circles as miles? That's what we did for googleMap()
. But perhaps we should go metric and use km instead.
Deprecating the google routines sounds like an excellent plan. I can update the roadless USA materials once there is a prototype of the new routines.
All the best,
Nick
On Jan 10, 2019, at 10:58 PM, Randall Pruim notifications@github.com wrote:
Should we keep the unit for the circles as miles? That's what we did for googleMap(). But perhaps we should go metric and use km instead.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
Should be all set to go. It works a little differently. If you provide multiple locations, you get one map with multiple markers and circles. Then you have to navigate around a bit if you need to zoom in on each marker.
I'm adding a unit
argument (one of "miles", "km", or "meters"). I'll leave miles as the default, I think, so things are more like googleMap()
. But I could easily be convinced that "km" is proper default.
On the other hand, if we are going to switch default units, now is the time. Perhaps "km" is the way to go for the default.
Also changing name of argument to units
so that either units
or unit
will work. "km" is now the default.
Having spent a week driving around England in October, I can report that road distances are measured in miles there. (And currency is measured in pounds!)
Not so in Canada, Australia, New Zealand.
But this isn't a reason to revisit the matter. Forward into the metric future! Long live the post-Brexit Commonwealth!
-Danny
On Fri, Jan 11, 2019 at 8:22 AM Randall Pruim notifications@github.com wrote:
Also changing name of argument to units so that either units or unit will work. "km" is now the default.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ProjectMOSAIC/mosaic/issues/721#issuecomment-453531927, or mute the thread https://github.com/notifications/unsubscribe-auth/AAggrQFuwx_NG7_t_0Mi7zEobdGi7h4gks5vCJ4sgaJpZM4YACLv .
--
...
DeWitt Wallace Professor of Mathematics, Statistics, and Computer Science Macalester College
library(mosaic) googleMap(40.7566, -73.9863, radius=1)
is now yielding messages about "for development purposes only" with minimal access to the older features.
Is there a workaround using Open Street Maps?