search

ProjectMOSAIC / mosaic

Project MOSAIC R package
http://mosaic-web.org/
93 stars 26 forks source link

Changing environment referred to in pfun() #782

Open dtkaplan opened 3 years ago

dtkaplan commented 3 years ago

This fixes a problem which made findZeros() not work in a {learnr} document deployed on a server like shinyapps.io which farms out the execution of chunks. (Not a problem for those using {learnr} via a desktop or rstudio.cloud or, presumably, any shiny server that doesn't farm out execution.)

The revised package checks cleanly.

I'll rely on @rpruim to merge this pull request in the correct way. There isn't any huge urgency on my part, since I've installed the issue-781 branch using install_github() and shinyapps.io will take it from there also.

There may be other old {mosaic} functions that will have the same problem with {learnr} on shinyapps.io. I haven't found them yet.

dtkaplan commented 3 years ago

Ach! I forgot to bump the version number @rpruim .