search

ProjectMirador / m1

An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations. This repository is no longer maintained, for further project details, see the latest version at http://github.com/IIIF/mirador.
Other
40 stars 9 forks source link

Unable to work with a url-escaped image identifier when there is no `identifier` field #135

Open hashimmm opened 10 years ago

hashimmm commented 10 years ago

In the case where the @id received from an image information (info.json) request contains a url-escaped image identifier component, and there is no identifier field, for example: "@id": "scheme://host:port/prefix/url%20escaped%2Fidentifier"

Mirador seems to incorrectly specify the tilesUrl for OpenSeaDragon (even though simply creating an OpenSeaDragon viewer separately and specifying the info request url as tilesUrl will work). Mirador displays thumbnails for the given image just fine, there's only an issue when prepping info for OSD.

According to the image API specification the identifier field shouldn't be required.

This can be fixed by changing json.identifier = matches[2]; to json.identifier = decodeURIComponent(matches[2]); in getImageHostUrl in iiif.js.

azaroth42 commented 10 years ago

+1

On Thu, Jul 17, 2014 at 12:17 AM, Hashim Muqtadir notifications@github.com wrote:

In the case where the @id received from an image information (info.json) request contains a url-escaped image identifier component, and there is no identifier field, for example: "@id": "scheme://host:port/prefix/url%20escaped%2Fidentifier"

Mirador seems to incorrectly specify the tilesUrl for OpenSeaDragon (even though simply creating an OpenSeaDragon viewer separately and specifying the info request url as tilesUrl will work). Mirador displays thumbnails for the given image just fine, there's only an issue when prepping info for OSD.

According to the image API specification http://www-sul.stanford.edu/iiif/image-api/1.1/#info the identifier field shouldn't be required.

This can be fixed by changing json.identifier = matches[2]; to json.identifier = decodeURIComponent(matches[2]); in getImageHostUrl in iiif.js.

— Reply to this email directly or view it on GitHub https://github.com/IIIF/mirador/issues/135.

Rob Sanderson Technology Collaboration Facilitator Digital Library Systems and Services Stanford, CA 94305