ProjectMirador / m1

An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations. This repository is no longer maintained, for further project details, see the latest version at http://github.com/IIIF/mirador.
Other
40 stars 9 forks source link

Framed annotation regions which are taller than they are wide do not take into account the occlusion of the bottom panel when focused. #57

Open aeschylus opened 10 years ago

aeschylus commented 10 years ago

When focusing a vertically rectangular annotation region, the canvas zooms and pans to focus the region, and when it does, it fits the viewport to the height of the annotation. However, if the bottom panel is displayed (which is the default state when focusing an annotation), the black gradient of the panel occludes the bottom 20% of the annotation region.

The viewport should therefore take into account the height of the bottom panel, if shown, and adjust the viewport dimensions accordingly, so that the annotation region is fully framed above the bottom detail panel.

Furthermore, if the panel is then hidden in the midst of examining the focused annotation, the viewport should adjust to fill the newly available space with the focused annotation region.