Open MImranAsghar opened 3 years ago
@MImranAsghar Thanks for working on this. I have some comments that are strictly about the visual design; I will leave it to others to weigh in on the more technical aspects (though I might have thoughts on the overall user experience as you get additional parts of the feature completed).
I realize that you are probably more focused on the functionality of this feature than the visual design at this point (understandably) but I want to make sure contributors are conscious of following existing Mirador 3 patterns when creating new UI elements. Ideally we'd have some form of detailed guide for Mirador 3 visual design, which would make it easier for developers. We already have divergence in some of the other Mirador 3 plugins so lacking a detailed style guide I want to point out these things so we can minimize further divergence.
@MImranAsghar Thanks for working on this. I have some comments that are strictly about the visual design; I will leave it to others to weigh in on the more technical aspects (though I might have thoughts on the overall user experience as you get additional parts of the feature completed).
I realize that you are probably more focused on the functionality of this feature than the visual design at this point (understandably) but I want to make sure contributors are conscious of following existing Mirador 3 patterns when creating new UI elements. Ideally we'd have some form of detailed guide for Mirador 3 visual design, which would make it easier for developers. We already have divergence in some of the other Mirador 3 plugins so lacking a detailed style guide I want to point out these things so we can minimize further divergence.
MuiTypography-h3
for these headings.Hi, Thanks for pointing these out. All your comments look very useful, I will start looking into these one by one and make the required changes 👍