search

ProjectMirador / mirador-annotations

a Mirador 3 plugin that adds annotation creation tools to the user interface
https://mirador-annotations.netlify.app/
38 stars 37 forks source link

Mark the current line-weight as selected; fixes #36 #60

Closed cbeer closed 2 years ago

cbeer commented 3 years ago

Screen Shot 2021-06-16 at 09 45 12

ggeisler commented 3 years ago

This might be a separate issue that I'm just lumping in with the one solved by this PR but I expect the line-weight menu to show the current option even when editing an existing annotation. For example, below I created an annotation (with the text "10") using a line-weight selection of 10. But after saving, when I edit that annotation and choose the line-weight option menu, the 1 option is shown as selected. I expect to see the 10 option selected:

Screen Shot 2021-06-16 at 3 42 37 PM
cbeer commented 3 years ago

I'll have to look at that; it's definitely different than this, and i'm a little worried that we'll have to... dive into the svg to figure out (and.. uh.. if there's multiple shapes on a single annotation, pick our favorite?)

ggeisler commented 3 years ago

Ah, good point. I didn't think about the multiple shapes case. Use your judgement about how much to look into what you can do; this isn't a critical thing from my point of view, especially now that you've pointed out the multiple shape complication.