search

ProjectMirador / mirador-annotations

a Mirador 3 plugin that adds annotation creation tools to the user interface
https://mirador-annotations.netlify.app/
38 stars 37 forks source link

React 16/17 conflict #68

Open chchch opened 2 years ago

chchch commented 2 years ago

Hi,

I can't seem to build this —mirador currently requires react@^16.8.3, which is conflicting with mirador-annotations which requires react@^17.0.

Thanks!

D-Groenewegen commented 1 year ago

I ran into this myself. Is it safe to use the --force flag, or would that break things?

chchch commented 1 year ago

I actually did manage to compile it eventually... I guess I used --force? This is what the dependencies in my package.json file look like:

  "dependencies": {
    "mirador": "^3.3.0",
    "mirador-annotations": "^0.5.0",
    "mirador-image-tools": "^0.11.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "url": "^0.11.0"
  }
D-Groenewegen commented 1 year ago

[Edited - spoke to soon]

Unfortunately no luck on my end.

lpoujade commented 1 year ago

We got it working with version 0.4.0 of this plugin, which use react 16