ProjectMirador / mirador

An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations.
https://projectmirador.org
Apache License 2.0
548 stars 258 forks source link

No support for nested ranges #1439

Closed tpendragon closed 3 years ago

tpendragon commented 7 years ago

https://plum.princeton.edu/concern/scanned_resources/ps75276654/manifest doesn't display the table of contents in Mirador, but it works in UV. Looks like Mirador doesn't support nested ranges - nor does it recognize the "top" viewingHint.

aeschylus commented 7 years ago

Hm. I believe it supports both, but there were some edge cases that didn't get covered. Adding some references here that may be related (and so we have access to this manifest while addressing those other issues).

https://github.com/ProjectMirador/mirador/issues/1427 https://github.com/ProjectMirador/mirador/issues/1140 See https://github.com/ProjectMirador/mirador/issues/1140#issuecomment-250608748

There seems to be a problem in https://github.com/ProjectMirador/mirador/blob/develop/js/src/widgets/toc.js#L144-L231

azaroth42 commented 7 years ago

IIIF Presentation API 2.1 does not support nested ranges.

References to ranges within the current range. Each included range must be referenced via a string containing the range’s URI.

This is a feature that is coming in 3.0

tpendragon commented 7 years ago

Ha! We've always used nested ranges because it made sense, and it worked in UV so we assumed we had it right.

mejackreed commented 3 years ago

@tpendragon do you have any handy examples of this that are public? We are thinking this is resolved in Mirador 3 and would love to test it.

tpendragon commented 3 years ago

@mejackreed We don't do nested ranges anymore - we switched to the 2.1 spec when we moved everything over from Plum to Figgy. The manifest referenced in this ticket is https://figgy.princeton.edu/concern/scanned_resources/f008d403-fe9c-4d62-ac50-7ab734b6f3c6/manifest now.

mejackreed commented 3 years ago

Awesome it seems to working well. Thanks for the quick response! Screen Shot 2020-10-08 at 5 25 31 PM