Performance optimizations needed for Annotation companion window when their are many annotations

ProjectMirador / mirador

An open-source, web-based 'multi-up' viewer that supports zoom-pan-rotate functionality, ability to display/compare simple images, and images with annotations.

https://projectmirador.org

Apache License 2.0

550 stars 256 forks source link

Performance optimizations needed for Annotation companion window when their are many annotations #2915

Open mejackreed opened 4 years ago

mejackreed commented 4 years ago

Using manifest https://iiif.europeana.eu/presentation/9200301/BibliographicResource_3000126341277/manifest after #2914 is merged. This newspaper page has 2292 annotations. The annotations panel is causing a page slowdown when rendering.

pixelomo commented 4 years ago

any updates on this issue @mejackreed ?

mejackreed commented 4 years ago

There were some performance optimizations in https://github.com/ProjectMirador/mirador/pull/2920 for manifest selections. I'm not sure of anyone who has looked at this issue yet. However I think a few approaches could help:

look to see if there is an expensive select happening many times, if so memoize it using re-reselect (similar to #2920)
look at windowing the annotation list display using react-window
see if there are design considerations that could help (with 1000's of annotations on a canvas, should/could we implement pagination?)

mejackreed commented 4 years ago

And to be clear, we would be open to a pull request from anyone that aimed to resolve these performance issues.

pixelomo commented 4 years ago

thanks for the advice will look into using reselect / react-window we're loading over 2000 annotations which is no doubt slowing it down. If we have any success developing a plugin for this we'll submit a pull request

pixelomo commented 4 years ago

@mejackreed I have another issue https://github.com/ProjectMirador/mirador/issues/2971 any chance you could help?