search

ProjectOpenSea / embeddable-nfts

Easily embed OpenSea listings in your website!
330 stars 139 forks source link

Update package versions, remove dead code #49

Closed fafrd closed 2 years ago

fafrd commented 2 years ago

Three things in this PR:

  1. Update a lot of packages. Some things are still not quite up to date, like webpack, which had breaking changes between version 4 and 5... and tslint, which is deprecated, it should be replaced with eslint but this was a bit involved (there seem to be some major issues with their indent rule??)
  2. Did a bit of refactoring to kill off dead code. This package used to have functionality to allow users to buy an NFT directly from the embed, but this was partly removed in c09a685; in this PR i've fully removed the remaining functionality.
  3. Fix the flip card functionality- example of how it's broken. We use an obscure css property called backface-visibility, I think this used to not be properly supported in browsers but now it is. Fixed by passing down the 'is-flipped' state to the child front/back components.

Resolves #44, #29, #31, #22, #25, #28, #30, #35, #41, #38

fafrd commented 2 years ago

Are you able to share more specifics about how you tested the dependency upgrades and the backface update, and how you ensured the dead code is dead?

Essentially I just tested this out in a few browsers (chrome, firefox and safari) and ensured everything worked manually. It's a basic enough project that I feel pretty confident in this.