ProjectOpenSea / operator-filter-registry

MIT License
312 stars 93 forks source link

Default example doesn't work without working tokenURI #19

Closed iainnash closed 1 year ago

iainnash commented 1 year ago

After trying to get royalty fees working on görli, I realized that a valid tokenURI is required to get the controls for creator fees working.

The examples here return a blank tokenURI and it could be replaced with an example token such as https://www.721.so/api/example/metadata/1.

Slokh commented 1 year ago

tokenURI should not be required, can you try deploying without it again? A mint is required though so that the collection can get instantiated.

iainnash commented 1 year ago

https://goerli.etherscan.io/address/0xf1fce304a4353c2f7f359686e9105369af4b8c26#code

Screen Shot 2022-11-10 at 10 06 01 PM

Shows an example of a token with no token uri and 3 mints that doesn't show the editing field.

Same code with tokenURI: https://goerli.etherscan.io/address/0x7a774798f652b959d9cad041c27d90910b4cbf82#readContract

Screen Shot 2022-11-10 at 10 08 07 PM
itsanishjain commented 1 year ago

It's working thanks

itsanishjain commented 1 year ago

Thanks @iainnash working with ERC721A

ashrhmn commented 1 year ago

Hey @iainnash , I can see the creators fee is enabled on OpenSea for my collection. But my contract URI response contains a seller fee basis points and the address which should be automatically set to royalty destination and percentages(It was working before 8th November). But my royalty percentage is always set to 0% right now even after implementing the DefaultOperatorFilterer and adding modifier to all transfer functions. contractURI response is parsed correctly, I can confirm, as the collection name and other details are shown properly. Both tokenURI and contractURI has valid data (Not IPFS, but an HTTP address)

image image

Is this the expected behavior right now or am I missing something? Can you confirm?

operatorfilterer commented 1 year ago

We are investigating this issue as related to OpenSea's ingestion of new collections – setting a tokenURI should not be required for creator fee enforcement.

operatorfilterer commented 1 year ago

Closing, as Goerli validation has been updated - please create a new issue if you run into similar problems.