ProjectOpenSea / operator-filter-registry

MIT License
312 stars 93 forks source link

Upgrade contract is not working #44

Closed moonfunjohn closed 1 year ago

moonfunjohn commented 1 year ago

I upgraded my ERC1155 contract yesterday but OpenSea still say "This collection is not eligible for creator fees" in the collection edit page.

I followed the example : https://github.com/ProjectOpenSea/operator-filter-registry/blob/main/src/example/upgradeable/ExampleERC1155Upgradeable.sol and added the following methods into my old contract

function setApprovalForAll(address operator, bool approved) public override onlyAllowedOperatorApproval(operator) { super.setApprovalForAll(operator, approved); }

function safeTransferFrom(address from, address to, uint256 tokenId, uint256 amount, bytes memory data)
    public
    override
    onlyAllowedOperator(from)
{
    super.safeTransferFrom(from, to, tokenId, amount, data);
}

function safeBatchTransferFrom(
    address from,
    address to,
    uint256[] memory ids,
    uint256[] memory amounts,
    bytes memory data
) public virtual override onlyAllowedOperator(from) {
    super.safeBatchTransferFrom(from, to, ids, amounts, data);
}

After upgrading my old contract on Ethereum Mainnet, nothing changed in my collection editing page, it still say "This collection is not eligible for creator fees".

Slokh commented 1 year ago

What's the address?

operatorfilterer commented 1 year ago

Closing for now as we do not have a contract address to debug; please reopen if you're still having the issue and are able to provide a contract address.