Closed balajmarius closed 1 year ago
OpenSea team, can we get this merged and released soon?
@operatorfilterer What's the timeline on this feature?
Thanks for the PR! The underlying contracts and patterns have changed a bit since it was opened. Can you update to follow the newer patterns in the main branch? Namely upgradeable storage layouts, constants, internal _checkFilterOperator
function calls. Then we can get that merged in. Thanks!
I would really appreciate this change!
@operatorfilterer thanks for the update! will add the indicated changes asap
Added needed changes. Tests specific for the contract can be run using forge test --match-contract UpdatableERC721Upgradeable -vvv
@operatorfilterer could you take a look?
@operatorfilterer We're blocked by this so we'd greatly appreciate it if we could get this in
Hello @operatorfilterer do you have an ETA on the above approval? We're assessing whether to fork at this point or see if we can wait, thanks
@operatorfilterer thank you! Would you mind releasing a new version that includes this change as an npm package?
An abstract contract whose init function automatically registers and optionally subscribes to or copies another registrant's entries in the
OperatorFilterRegistry
. This contract allows theOwner
to update theOperatorFilterRegistry
address viaupdateOperatorFilterRegistryAddress
, including to the zero address, which will bypass registry checks.Note that OpenSea will still disable creator fee enforcement if filtered operators begin fulfilling orders on-chain, eg, if the registry is revoked or bypassed.
This smart contract is meant to be inherited by token contracts so they can use the following:
onlyAllowedOperator
modifier fortransferFrom
andsafeTransferFrom
methods.onlyAllowedOperatorApproval
modifier forapprove
andsetApprovalForAll
methods.Also, use
updateOperatorFilterRegistryAddress
function to change the registry address if needed.