search

ProjectOpenSea / seaport-js

A TypeScript library to interface with the Seaport marketplace.
MIT License
250 stars 182 forks source link

Scale tip amounts to partial fills when using fulfillOrders (fulfillAvailableAdvancedOrders) #558

Closed frankisawesome closed 1 month ago

frankisawesome commented 1 month ago

Component

API

Have you ensured that all of these are up to date?

What version of seaport-js are you on?

latest

What function is the bug in?

fulfillOrders

Operating System

None

Describe the bug

When calling fulfillOrders with a partial order fulfillment and using a tip, the tip amount is not scaled to the fulfillment proportion. This behaviour was fixed in fulfillOrder.

I intend to have a PR shortly fixing this 👍