Have you ensured that all of these are up to date?
[X] seaport-js
[ ] Node (minimum v16)
What version of seaport-js are you on?
4.0.2
What function is the bug in?
fulfillOrders
Operating System
macOS (Apple Silicon)
Describe the bug
When filling a partially filled order, if the unitsToFill parameter is not provided when invoking fulfillOrders this results in the transaction reverting with an overflow error. The expected behaviour is that the remaining quantity of the order is filled.
Scenario:
Creates a listing to sell 100 ERC1155 tokens at 1 ETH each.
Fill the listing partially by taking 50 units from the original order.
Attempt to fill the listing by invoking fulfillOrders without providing a unitsToFill value.
Transaction revert with overflow error.
As an extension to this, tips also need to be adjusted to cater to the scenario where an explicit unitsToFill value isn't provided.
Note: This issue is seen only in the fulfillOrders function.
Component
API
Have you ensured that all of these are up to date?
What version of seaport-js are you on?
4.0.2
What function is the bug in?
fulfillOrders
Operating System
macOS (Apple Silicon)
Describe the bug
When filling a partially filled order, if the
unitsToFill
parameter is not provided when invokingfulfillOrders
this results in the transaction reverting with anoverflow
error. The expected behaviour is that the remaining quantity of the order is filled.Scenario:
50
units from the original order.fulfillOrders
without providing aunitsToFill
value.overflow
error.As an extension to this, tips also need to be adjusted to cater to the scenario where an explicit
unitsToFill
value isn't provided.Note: This issue is seen only in the
fulfillOrders
function.