search

ProjectOpenSea / seaport-js

A TypeScript library to interface with the Seaport marketplace.
MIT License
250 stars 182 forks source link

[Minor] Improve error messaging for failed balance/approval checks #594

Closed frankisawesome closed 3 weeks ago

frankisawesome commented 3 weeks ago

Motivation

It's tough developer experience when prompted with the previous error message, resulting in quite some tinkling in my case, using npm link and logging things out to debug what's gone wrong in my set up. The change allows developers to find the cause of the balance/approval check fail at a glance.

Solution

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.67%. Comparing base (f618d19) to head (fc4f6b0). Report is 91 commits behind head on main.

Files Patch % Lines
src/utils/balanceAndApprovalCheck.ts 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #594 +/- ## ========================================== + Coverage 98.27% 98.67% +0.39% ========================================== Files 35 35 Lines 14526 15651 +1125 Branches 660 690 +30 ========================================== + Hits 14276 15444 +1168 + Misses 245 202 -43 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.