ProjectPhysX / FluidX3D

The fastest and most memory efficient lattice Boltzmann CFD software, running on all GPUs via OpenCL. Free for non-commercial use.
https://youtube.com/@ProjectPhysX
Other
3.48k stars 281 forks source link

INTERACTIVE_GRAPHICS_ASCII broken by the "Made camera movement/rotation/zoom behavior independent of framerate" feature? #191

Closed gitcnd closed 1 month ago

gitcnd commented 1 month ago

src/graphics.hpp:112:25: error: too few arguments to function call, single argument 'frametime' was not specified if(key=='W') input_W();


src/graphics.hpp:235:2: note: 'input_W' declared here
        void input_W(const double frametime) {
        ^

See https://github.com/ProjectPhysX/FluidX3D/commit/d2f18df30127a1e32279c16d9de968f15a3a85d6

Also - worth noting that with XQuartz installed, FluidX3D builds ( with ```LDLIBS_X11 = -L/opt/X11/lib -lX11 -lXrandr``` ) and is tantalisingly close to running OK on macOS, except for what looks like a graphics-mode-selection call?  

```
[cnd@mac FluidX3D]$ bin/FluidX3D
X Error of failed request:  BadRROutput (invalid Output parameter)
  Major opcode of failed request:  142 (RANDR)
  Minor opcode of failed request:  9 (RRGetOutputInfo)
  Serial number of failed request:  13
  Current serial number in output stream:  13
[cnd@mac FluidX3D]$ 
```
ProjectPhysX commented 1 month ago

Hi @gitcnd,

thanks a lot for reporting, that's what happens when I leave out only one test... Fixed it now.

Kind regards, Moritz