search

ProjectProtege / protege

Remote jobs for junior developers
protege.vercel.app
MIT License
67 stars 39 forks source link

Reenable eslint on build command #339

Open secondl1ght opened 2 years ago

secondl1ght commented 2 years ago

Closes #325

Description

As per @nickytonline description: On build now with NEXT.js 11, eslint runs as part of the build. Currently it's erroring out with the following lint errors. Reenable linting on builds and fix the lint errors.

Related Tickets and Documents

Issue #325

What gif best describes this PR or how it makes you feel? (optional)

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @drewclem on Vercel.

@drewclem first needs to authorize it.

nickytonline commented 2 years ago

@secondl1ght thanks so much for the PR! Removing the configuration to disable linting during the build is part of the issue. The other part is to fix all the lint issues currently being generated. I displayed all the lint issues in the issue, but rereading the issue now, I did not make it clear that the lint errors had to be fixed as well. Let me know if you need any assistance with that.

Looking forward to having this in production. 😎

secondl1ght commented 2 years ago

I think I will put in a separate PR for fixing the linter issues and we can merge them both at the same time.

nickytonline commented 2 years ago

I think I will put in a separate PR for fixing the linter issues and we can merge them both at the same time.

The lint fixes will need to be merged first and then we can merge this PR. Otherwise, the build will fail like it currently is in this PR.