Closed r-ford closed 1 year ago
My $0.02: we should completely get rid of the "outside contributor" status. It's not necessary and puts up an unhelpful silo around Pythia.
If you contribute something, you should be a member of the Pythia org.
We can and do use GitHub teams for more fine-grained control of access, review requests, etc.
Yep, that's what I've done for two contributions so far. "Demoting" to outside collaborator is limiting in some ways (eg repo settings) and may not be necessary, though it might make it easier to manage contributor access (and see the list of those) as we grow. Either way we should probably also add this as a step to the issue template in cookbook-gallery.
edit: a cookbook-contributor team or something could balance the organizational value with reducing the demotion headache.
I think it makes sense to abandon the outside collaborator role and use teams to organize permissions. It would be worth discussing the specifics at our next meeting, but for now I'll open a PR to reflect our current process without the demotion part (steps 1-3 above).
I may be absent from our next meeting, but my strong opinion is that we need to build a big tent. Making a habit of "demoting" people sends the wrong message. We need to be as inclusive as possible in our practices.
conda-forge uses a teams model to manage access. I'm a member of the (very large) conda-forge organization, which costs nothing but gives me a sense of inclusion. And I'm a team member on the small handful of repos that I'm a named maintainer of. I only have merge credentials on those repos. I think this model works well.
Section 4i currently reads
I think our current process would look something like
This might be a slightly awkward way of doing it, since it involves adding someone as a full member before "demoting" them, but I'm not sure if there is a more straightforward way. Our base permissions for members is read-only, so we may not even need to demote to outside collaborator. @dcamron Does this make sense based on your experience so far?