search

ProjectPythia / cmip6-cookbook

Examples of analysis of Google Cloud CMIP6 data using Pangeo tools
https://projectpythia.org/cmip6-cookbook/
Apache License 2.0
11 stars 10 forks source link

Update esgf example #43

Closed mgrover1 closed 1 year ago

mgrover1 commented 1 year ago

Update the ESGF example to use an improved API

github-actions[bot] commented 1 year ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: e42c6ff0e496fd2f925b401a3c8edff153f7d57a ✅ Deployment Preview URL: In Progress

r-ford commented 1 year ago

Looking at the build action, I see that "Update execution environment" is not running. I wonder if that's why trying to change the environment hasn't fixed this numba/numpy issue.

mgrover1 commented 1 year ago

Yeah - I opened a PR upstream (in the cookbook-actions repo) to fix this

mgrover1 commented 1 year ago

Despite this building the new environment, it looks like the cookbook action is still hardcoding the main branch

https://github.com/ProjectPythia/cookbook-actions/blob/main/.github/workflows/build-book.yaml#L145

Which means this won't pass until the updates to the environment are in the main branch... and the cookbook-action PR is merged. @r-ford should I go ahead and merge these to see if this fixes this issue?