Examples with secrets not executing

ProjectPythia / cmip6-cookbook

Examples of analysis of Google Cloud CMIP6 data using Pangeo tools

https://projectpythia.org/cmip6-cookbook/

Apache License 2.0

11 stars 9 forks source link

Examples with secrets not executing #48

Open mgrover1 opened 1 year ago

mgrover1 commented 1 year ago

What happened: Since the new ARM/ESGF example uses github secrets, we are running into issues passing those credentials to the execution workflow on the binderhub

What you expected to happen: We should be able to execute notebooks with secrets through the CI system, especially since binderbot explicitly allows this.

Anything else we need to know?: I opened a PR to resolve this over in https://github.com/ProjectPythia/cookbook-actions/pull/50

brian-rose commented 1 year ago

@mgrover1 is it true that https://github.com/ProjectPythia/cookbook-actions/pull/50 didn't fix this?

We're putting the "high priority" label here, but please close if this is already taken care of.

mgrover1 commented 1 year ago

Thanks @ktyle - planning on troubleshooting more tomorrow.

ktyle commented 11 months ago

@mgrover1 can this be closed now? Or are there still some unresolved issues?

brian-rose commented 11 months ago

I think there are some remaining unresolved issues with secrets and Pull Requests. I was tracking this work here: https://github.com/ProjectPythia/cookbook-actions/issues/77