search

ProjectPythia / cmip6-cookbook

Examples of analysis of Google Cloud CMIP6 data using Pangeo tools
https://projectpythia.org/cmip6-cookbook/
Apache License 2.0
11 stars 10 forks source link

ADD: Add new notebook calculating ENSO with intake-esgf #65

Closed mgrover1 closed 11 months ago

mgrover1 commented 12 months ago

Show how to use intake-esgf to access data, apply ENSO calculations, and visualize using hvPlot.

github-actions[bot] commented 12 months ago

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. 🔍 Git commit SHA: 39e228a7950e25feb8addae6e5c0588ba70a9081 ✅ Deployment Preview URL: https://ProjectPythia.github.io/cmip6-cookbook/_preview/65

r-ford commented 11 months ago

Nice! I'll take a look at this today.

It seems like the preview action is failing because the environment is not being updated to include intake_esgf. Is the solution to just update the env on main first, or is there some config option that can be set?

brian-rose commented 11 months ago

It seems like the preview action is failing because the environment is not being updated to include intake_esgf. Is the solution to just update the env on main first, or is there some config option that can be set?

This is a current limitation of our build actions (https://github.com/ProjectPythia/cookbook-actions/issues/77). This "edge case" of building on Binder with secrets and a change in the environment file is not something we currently handle. There are complications around the scope rules for using secrets that we haven't solved.

The workaround is as Rob says: open a simple PR just adding the new package to the environment file and merge it into main even though it won't build and preview properly. Then proceed with this PR.

mgrover1 commented 11 months ago

@brian-rose @r-ford - I submitted a PR with the suggested way forward 😄

mgrover1 commented 11 months ago

@brian-rose - unpinning numpy here brought back the numba issues... I will submit a PR to revert the numpy version.

mgrover1 commented 11 months ago

@brian-rose @r-ford numba is causing issues with the main execution environment. The opendap issue has been resolved, I am not sure what to do about rebuilding the conda environment for the book here. Those recent PRs did not trigger a reinstallation of numba.